On Mon, Jul 28, 2014 at 02:19:22PM +0200, Javier Martinez Canillas wrote:
> From: Derek Basehore <dbasehore@xxxxxxxxxxxx>
>
> Since the i2c bus can get wedged on the EC sometimes, set the number of retries
> to 3. Since we un-wedge the bus immediately after the wedge happens, this is the
> correct fix since only one transfer will fail.
>
> Signed-off-by: Derek Basehore <dbasehore@xxxxxxxxxxxx>
> Reviewed-by: Doug Anderson <dianders@xxxxxxxxxxxx>
> ---
> drivers/i2c/busses/i2c-cros-ec-tunnel.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/i2c/busses/i2c-cros-ec-tunnel.c b/drivers/i2c/busses/i2c-cros-ec-tunnel.c
> index 05e033c..a4411da 100644
> --- a/drivers/i2c/busses/i2c-cros-ec-tunnel.c
> +++ b/drivers/i2c/busses/i2c-cros-ec-tunnel.c
> @@ -16,6 +16,8 @@
> #include <linux/platform_device.h>
> #include <linux/slab.h>
>
> +#define I2C_MAX_RETRIES 3
I think a define for this is overkill, yet I don't really mind.
Acked-by: Wolfram Sang <wsa@xxxxxxxxxxxxx>
I assume this goes via MFD, let me know if I should take it.
> +
> /**
> * struct ec_i2c_device - Driver data for I2C tunnel
> *
> @@ -290,6 +292,7 @@ static int ec_i2c_probe(struct platform_device *pdev)
> bus->adap.algo_data = bus;
> bus->adap.dev.parent = &pdev->dev;
> bus->adap.dev.of_node = np;
> + bus->adap.retries = I2C_MAX_RETRIES;
>
> err = i2c_add_adapter(&bus->adap);
> if (err) {
> --
> 2.0.0.rc2
>
Attachment:
signature.asc
Description: Digital signature
