Re: [PATCH] hid: huion: Fix sparse warnings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 29 Jul 2014, Nikolai Kondrashov wrote:

> Fix sparse warnings in hid-huion.c by using correct buffer type for
> retrieved string descriptor.
> 
> The warnings in question were:
> 
>     drivers/hid/hid-huion.c:144:44: sparse: cast to restricted __le16
>     drivers/hid/hid-huion.c:145:44: sparse: cast to restricted __le16
>     drivers/hid/hid-huion.c:146:51: sparse: cast to restricted __le16
>     drivers/hid/hid-huion.c:147:30: sparse: cast to restricted __le16

Interestingly enough, my sparse doesn't seem to report this problem 
(running sparse is part of my machinery before pushing anything out).

> Signed-off-by: Nikolai Kondrashov <spbnick@xxxxxxxxx>
> ---
> 
> Hi Jiri, Benjamin,
> 
> Thanks for the review. There is one minor problem, though. I didn't run a
> sparse check and only just got a message with "sparse" warnings. This patch
> fixes them.
> 
> If you wouldn't like adding a tiny patch like this, I can send another version
> of the original patches. Otherwise, please feel free to just fixup my "Switch
> to generating report descriptor" commit with this one.

Yup, I'll be applying this on top of your previous one.

Thanks.

-- 
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux