On Fri, Jul 25, 2014 at 02:06:40PM -0600, Stephen Warren wrote: > On 07/25/2014 08:10 AM, Nick Dyer wrote: > >On 24/07/14 22:19, Stephen Warren wrote: > ... > >>I've uploaded 2 logs to: > >> > >>http://avon.wwwdotorg.org/downloads/mxt-logs/ > >>(note there's no directory indexing, so manually add the filenames below to > >>the URL) > >> > >>mxt-save-no-movement.xml > >> > >>This is with the whole series applied. Neither mouse movement nor clicks > >>works. I tried mxt-app --reset and it made no difference to the dump results. > >> > >>mxt-save-move-ok-no-clicking.xml > >> > >>This is with "Input: atmel_mxt_ts - use deep sleep mode when stopped" > >>reverted; mouse movement works, but clicking doesn't. > > > >Great, this has identified the issue with mouse movement (touch). > > > >The config programmed into the NVRAM on your touch controller has the first > >byte of the T9 touchscreen object set to zero. This is the CTRL byte which > >enables/disables the touch object and what it reports. It is relying on > >this to enable the touchscreen on resume: > > > >https://github.com/dtor/input/blob/9d8dc3e529/drivers/input/touchscreen/atmel_mxt_ts.c#L2005-L2006 > > > >My "use deep sleep mode when stopped" patch stops the driver writing to the > >T9.CTRL byte, so whatever config you have in NVRAM for that byte will be > >used (ie zero, disabled). Going forward, deep sleep is more generic. > >Indeed, newer chips do not have T9 at all, or they might be using other > >touch objects. The deep sleep mode is a lower power state to be in, and is > >what Atmel recommends. > > > >However, it does mean changing the maxtouch cfg - you can write the 0x83 to > >the first byte of T9 and save it to NVRAM, by doing: > > > >mxt-app [device] -W -T9 83 > >mxt-app [device] --backup > > If I do that, then both mouse movement and "touch" clicks work:-) > > (Dmitry, I guess that means it's fine to go ahead and apply "Input: > atmel_mxt_ts - use deep sleep mode when stopped".) OK, I've applied it (but because it now last I had to resolve a few conflicts so if somebody could take a peek at my next branch that would be great). Thanks. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html