On 29/06/14 12:49, Russell King - ARM Linux wrote:
On Sun, Jun 29, 2014 at 12:00:20PM +0100, Jonathan Cameron wrote:
On 21/06/14 20:55, Fabio Estevam wrote:
On Sat, Jun 21, 2014 at 7:18 AM, Jonathan Cameron <jic23@xxxxxxxxxx> wrote:
+
+ res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
Could this not in theory fail?
Yes, but devm_ioremap_resource will take care of it, so we don't need
to check for error here.
Nothing like counter intuitive behaviour. Ah well.
Thanks for explaining this!
Maybe it would be better to have:
mem = platform_ioremap_resource(pdev, IORESOURCE_MEM, 0);
which wraps up both the platform_get_resource() call with
devm_ioremap_resource() so driver writers don't have to be concerned
about this aspect?
Good idea.
Something like that would certainly make more sense to me.
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
