Hi, Am 28.06.2014 um 19:08 schrieb Pavel Machek: > Hi! > >> This gives the userspace (Replicant) a chance to fully handle the >> pm_wakeup_event, before autosleep suspends the system alltogether >> again. >> >> This fixes suspend/resume on the OpenPhoenux GTA04, in combination with >> the Replicant 4.2.2 userspace, which needs to execute this to stay >> awake: 'echo on > /sys/power/state' >> >> Signed-off-by: Lukas Märdian <lukas@xxxxxxxxxxxxx> >> Signed-off-by: H. Nikolaus Schaller <hns@xxxxxxxxxxxxx> > > I'm sorry, but we should not be doing this. > > You basically put a delay in driver to work around userspace bug. Do you think it is a user-space bug if the kernel goes to sleep again before giving user space any chance to react to an event? And the msec parameter is described as: @msec: Anticipated event processing time (in milliseconds). Isn't calling pm_wakeup_event() with a non-zero msec the standard method to handle this situation? And it is used in other drivers. E.g. in _mmc_detect_change() or hub_suspend(). And if I understand the code of __pm_wakeup_event() correctly it does *not* delay, but just modifies the wakeup_source timer to expire a little later. I.e. keep the system longer awake. So as long as the system is not suspended there is no difference to current driver. > There must be better > solution.... I am not sure how it could look like. -- hns-- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
