On Wed, Jun 25, 2014 at 03:46:19PM -0700, Bryan Wu wrote: > On Wed, Jun 25, 2014 at 10:08 AM, Johan Hovold <johan@xxxxxxxxxx> wrote: > > LED-class device attributes should be created using the attribute groups > > of struct device, rather than be added manually after the device has > > been registered in order to avoid racing with userspace. > > > > The first patch adds an attribute groups field to struct led_classdev, > > which is used during registration to add device attributes in a > > race-free manner. > > > > The remaining patches convert the current racy LED-device attribute > > creations to use the new facility. Hopefully my grep-patterns have > > caught most instances. Note that this also tends to simplify probe error > > paths. > > > > The lp55xx-common failed to remove the attribute group it is currently > > creating, something which is fixed separately. > > > > Note that this series include one driver from drivers/input/keyboard. > > > > The individual led-driver patches have been compile tested only. > > > > Thanks a lot for driving this. I will applied this patchset into my > -devel branch. After I got the Ack from Input guys, I will apply it to > my for-next branch then. Series looks good to me, Johan, thanks for doing this work. greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html