Re: [RFC] Input: uinput - add new UINPUT_DEV_SETUP ioctl

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi

On Fri, Jun 20, 2014 at 1:10 PM, David Herrmann <dh.herrmann@xxxxxxxxx> wrote:
>>> + *             abs: This is an appended array that contains parameters for ABS
>>> + *                  axes. See "struct input_absinfo" for a description of these
>>> + *                  fields. This array is copied unchanged into the kernel for
>>> + *                  all specified axes. However, to have effect, you must also
>>> + *                  enable the wanted axes via UI_SET_ABSBIT.
>>
>> last sentence: "Only axes previously enabled with UI_SET_ABSBIT are copied."
>
> This is not true. All axes are copied. That's how uinput always
> worked. You can set UI_SET_ABSBIT after SETUP. However, given that we
> do the "uinput_validate_absbits" only on SETUP, you would get weird
> errors during UI_DEV_CREATE if the axis data was invalid (afaik
> uinput_register_device() validates those values. Not sure, though).

Ok, I changed my mind again. I now explicitly ignore any axes not
enabled via UI_SET_ABSBIT. I think you're right and that's how users
would expect this to work.

Thanks
David
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux