On Thu, 12 Jun 2014 09:56:41 +0100 (BST) Jamie Lentin <jm@xxxxxxxxxxxx> wrote: > On Wed, 11 Jun 2014, Antonio Ospite wrote: > [...] > >> +static int tpcompactkbd_input_mapping(struct hid_device *hdev, > > > > Maybe name these functions like tpkbd_input_mapping_compact()? > > > > This way the namespace is more consistent, and follows the logic of > > patch 1/2 more closely. > > > > Use this scheme at least for functions which have a _tp() counterpart. > > Previously the tpkbd driver had various functions marked "_tp" to indicate > that it's for the "mouse" half of the keyboard as the kernel sees it, > however it does nothing special with the keyboard half. I was intending > (somewhat sloppily) to repurpose this into having versions of each > function for each keyboard, and a common function to switch between them. > Should make it fairly easy to add extra keyboards in the future. > > The problem, as ever, is choosing decent names for them. It should > probably be either:- > > * tpkbd_input_mapping_usbkbd > * tpkbd_input_mapping_compactkbd > ...and tpkbd_input_mapping switches between them > > or rename the driver to hid-lenovo and do:- > I am OK with a rename. Most files in drivers/hid are per-vendor after all. Jiri? > * lenovo_input_mapping_tpkbd > * lenovo_input_mapping_compacttp I think you meant lenovo_input_mapping_compactkbd ? :) > ...and lenovo_input_mapping switches between them > > The latter seems a bit too invasive, but I'm not sure how obvious with the > former that it'd be that the "Compact USB keyboard" is in-fact a > compactkbd not a usbkbd. The former is probably what I'll go for unless > you have any thoughts. > [...] Ciao, Antonio -- Antonio Ospite http://ao2.it A: Because it messes up the order in which people normally read text. See http://en.wikipedia.org/wiki/Posting_style Q: Why is top-posting such a bad thing? -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
