Re: [PATCH v3] leds: USB: HID: Add support for MSI GT683R led panels

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jun 11, 2014 at 01:25:49PM +0200, Jiri Kosina wrote:
> On Wed, 11 Jun 2014, Janne Kanniainen wrote:
> 
> > This driver adds support for USB controlled led panels that exists in MSI GT683R laptop
> > 
> > Changes in v2:
> > 	- sorted headers to alphabetic order
> > 	- using devm_kzalloc
> > 	- using BIT(n)
> > 	- using usb_control_msg instead of usb_submit_urb
> > 	- removing unneeded code
> > 
> > Changes in v3:
> > 	- implemented as HID device
> > 	- some cleanups and bug fixes
> > 
> > Signed-off-by: Janne Kanniainen <janne.kanniainen@xxxxxxxxx>
> 
> Thanks for the driver. Johan, as you did a very good job reviewing this 
> before I managed to get to it, I'd be glad to put your Reviewed-by: to the 
> commit before commiting it, if you are going to provide it.

I had a few more comments to v3, but I'll make sure to reply with a
Reviewed-by-tag before you apply.

Thanks,
Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux