Re: [PATCH] hid: Add custom driver for Lenovo ThinkPad Compact Bluetooth Keyboard

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 20 May 2014, Jiri Kosina wrote:

On Tue, 25 Mar 2014, Jamie Lentin wrote:

This keyboard requires some custom mappings for all keys to be
available, and the Fn-lock toggle needs to be controlled in software.

Signed-off-by: Jamie Lentin <jm@xxxxxxxxxxxx>
---
I assume that Linux users want Fn-Lock enabled by default, so they can
get at the function keys. If this is an incorrect assumption then can
change it---so long as there's some way of me leaving it enabled :)

Tested with and applies cleanly to 3.13.6.

 drivers/hid/Kconfig                   |  10 ++
 drivers/hid/Makefile                  |   1 +
 drivers/hid/hid-core.c                |   3 +
 drivers/hid/hid-ids.h                 |   1 +
 drivers/hid/hid-lenovo-tpcompactkbd.c | 191 ++++++++++++++++++++++++++++++++++
 5 files changed, 206 insertions(+)

Jamie,

thanks for the driver.

I think it'd make more sense if this could be folded into hid-lenovo-tpkbd
driver. Could you please do that and resubmit?

I can do if required, although I didn't originally since there would be no common code whatsoever between the keyboards. The newer keyboard has no leds to register, and no trackpoint settings are exposed like on the older keyboard. Equally the newer Fn-Lock setting wouldn't make sense for the older keyboards, since they have grown-up function keys. The similarity stops with the name.

I have both the USB and the Bluetooth versions of this keyboard now, once I have finished support for both[0] I will resubmit support for both.

Cheers,

[0] https://github.com/lentinj/tp-compact-keyboard/blob/usb-keyboard-support/module/hid-lenovo-tpcompactkbd.c
    if anyone is interested

--
Jamie Lentin
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux