Hello Carlo, On 11/04/2014 11:38, Carlo Caione wrote: > AXP202 and AXP209 come with two synchronous step-down DC-DCs and five > LDOs. This patch introduces basic support for those regulators. > > Signed-off-by: Carlo Caione <carlo@xxxxxxxxxx> > --- > drivers/regulator/Kconfig | 7 + > drivers/regulator/Makefile | 1 + [...] > + if (!np) > + return 0; > + > + regulators = of_find_node_by_name(np, "regulators"); I know I'm late, and this patch has already been applied, but shouldn't we use of_get_child_by_name instead of of_find_node_by_name. This might lead to wrong regulators node parsing if other regulators are defined in the DT after the axp20x node, because, AFAIK, this function searches for DT nodes defined after the specified np node, but not necessarely children of the np node. Best Regards, Boris -- Boris Brezillon, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
