On Tue, Apr 29, 2014 at 06:55:49AM +0400, Alexander Shiyan wrote: > Mon, 28 Apr 2014 19:21:04 -0700 от Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>: > > Hi Alexander, > > > > On Sat, Apr 26, 2014 at 09:46:54AM +0400, Alexander Shiyan wrote: > > > + beep->desc = devm_gpiod_get(&pdev->dev, NULL); > > > + if (!beep->desc) > > > + return -EINVAL; > > > > As far as I can see devm_gpiod_get() never returns NULL, but either a > > valid pointer or ERR_PTR-encoded error. Why do we check for NULL? > > > > I can drop the check myself, no need to resubmit. > > OK. > > ... > > One issue you keep value argument for gpio_beeper_toggle() as bool. > It should be "int" as in original patch, as well as "beeping" value in > private struct. Not really, value of gpio_set_value_cansleep() is a boolean, even though the type is int. I guess using 'int' is historical. One can't really set gpio value to let's say 5. Thanks. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
