On Fri, Apr 25, 2014 at 6:38 PM, Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx> wrote: > On Fri, Apr 25, 2014 at 10:13:43AM +0200, Olivier Gay wrote: > This table already has entries for KEY_BRIGHTNESS_UP/DOWN, you are > overriding them. I'd rather we did not define gratuitous aliases > (sometimes aliasing is necessary when we got the name wrong, but UP/DOWN > vs INC/DEC for brightness is not the case here). Done. You didn't mention KEY_BRIGHTNESS_TOGGLE so I kept it. > I was looking through keycodes again and we have: > > #define KEY_BRIGHTNESS_ZERO|----244|----/* brightness off, use ambient */ > > which seems to be exactly the same as KEY_BRIGHTNESS_AUTO, but here I > agree that old name is not the best. Could you please change its > definition earlier in the file to: > > #define KEY_BRIGHTNESS_AUTO 224 /* Set Auto Brightness: manual > brightness control is off, > rely on ambient */ > #define KEY_BRIGHTNESS_ZERO KEY_BRIGHTNESS_AUTO Changes done. I'm sending v4 right now. Best regards, Olivier -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
