On Wed, Apr 23, 2014 at 02:12:59PM +0200, Oliver Neukum wrote:
> On Tue, 2014-04-22 at 15:59 +0200, Michal Malý wrote:
> > +/* Some devices might have a limit on how many uncombinable effects
> > + * can be played at once */
> > +static int mlnx_upload_conditional(struct mlnx_device *mlnxdev,
> > + const struct ff_effect *effect)
> > +{
> > + struct mlnx_effect_command ecmd = {
> > + .cmd = MLNX_UPLOAD_UNCOMB,
> > + .u.uncomb.id = effect->id,
> > + .u.uncomb.effect = effect
> > + };
> > + return mlnxdev->control_effect(mlnxdev->dev, mlnxdev->private,
> > &ecmd);
> > +}
> > +
>
> This mean you are building the structure on the stack
>
> 1. Are you sure nobody retains a reference?
> 2. That is needlessly inefficient
Why is it inefficient?
--
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
