On Fri, Apr 11, 2014 at 2:29 PM, Mark Brown <broonie@xxxxxxxxxx> wrote:
> On Fri, Apr 11, 2014 at 11:38:11AM +0200, Carlo Caione wrote:
>
>> In all the DTs the min and max microvolt allowed for each regulator are actually
>> the min and max voltage possible for the regulator itself. This is not safe but
>> we do not have the ranges allowed for each board and the original Allwinner
>> driver does exactly this way.
>
> Is there any code in their kernel which varies the supply voltages? If
> there isn't then simply omitting the voltage ranges is the best option,
> leaving the supplies fixed. If there is then the range it uses is a
> good starting point. In general supplies will be fixed voltage on a
> given board unless there is a specific reason to vary them.
The supply voltage (ipsout) for the regulators is fixed and AFAIK
there is no code for changing it.
I'll omit the voltage ranges then.
>> + regulators {
>> + compatible = "x-powers,axp20x-reg";
>
> This compatible isn't part of the driver.
Yes I know. The problem here is that in v4 I had to fill in the field
.of_compatible of the mfd_cell with "x-powers,axp20x-reg". This
because the regulator_dev_lookup() checks for dev->of_node when
looking for the supply so I needed the compatible string in the DT to
have the dev->of_node filled in by mfd_add_device().
What do you suggest? Modify the regulator driver?
Thank you,
--
Carlo Caione
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
