Hi Hans, On Wed, Apr 09, 2014 at 04:02:59PM +0200, Hans de Goede wrote: > Serio device drivers need access to the pnp_id of the serio port, windows > drivers bind by the pnp-id and some drivers need to know the exact pnp-id > used so they know exactly with which hardware model / revision they are > dealing with. > > Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx> > --- > include/linux/serio.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/include/linux/serio.h b/include/linux/serio.h > index 9f779c7..6532440 100644 > --- a/include/linux/serio.h > +++ b/include/linux/serio.h > @@ -16,6 +16,7 @@ > #include <linux/mutex.h> > #include <linux/device.h> > #include <linux/mod_devicetable.h> > +#include <linux/pnp.h> > #include <uapi/linux/serio.h> > > struct serio { > @@ -28,6 +29,7 @@ struct serio { > bool manual_bind; > > struct serio_device_id id; > + struct pnp_id *pnp_id; Why do we need this if we are already adding generic 'firmware_id' attribute? Thanks. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html