On Sat, Apr 5, 2014 at 5:26 PM, Sebastian Reichel <sre@xxxxxxxxxx> wrote: > Add common DT binding documentation for touchscreen devices and > implement input_parse_touchscreen_of_params, which parses the common > properties and configures the input device accordingly. Good. > > Signed-off-by: Sebastian Reichel <sre@xxxxxxxxxx> > --- > .../bindings/input/touchscreen/touchscreen.txt | 9 ++++++ > drivers/input/input.c | 34 ++++++++++++++++++++++ > include/linux/input.h | 8 +++++ > 3 files changed, 51 insertions(+) > create mode 100644 Documentation/devicetree/bindings/input/touchscreen/touchscreen.txt > > diff --git a/Documentation/devicetree/bindings/input/touchscreen/touchscreen.txt b/Documentation/devicetree/bindings/input/touchscreen/touchscreen.txt > new file mode 100644 > index 0000000..a2ff0a0 > --- /dev/null > +++ b/Documentation/devicetree/bindings/input/touchscreen/touchscreen.txt > @@ -0,0 +1,9 @@ > +General Touchscreen Properties: > + > +Optional properties for Touchscreens: > + - touchscreen-size-x : horizontal resolution of touchscreen > + - touchscreen-size-y : vertical resolution of touchscreen While I like the consistency, x-size and y-size are already commonly used. Perhaps the common binding should have both and x-size/y-size be marked deprecated. > + - touchscreen-max-pressure : maximum reported pressure > + - touchscreen-fuzz-x : horizontal noise value of the absolute input device > + - touchscreen-fuzz-y : vertical noise value of the absolute input device > + - touchscreen-fuzz-pressure : pressure noise value of the absolute input device What are the units or are they just an arbitrary range dependent on the controller? Several existing bindings appear to be in pixels, but that seems wrong to me. There's also these various properties that should have common versions created: ti,x-plate-resistance and ti,x-plate-ohms (tsc2007) - rohm,flip-x : Flip touch coordinates on the X axis - rohm,flip-y : Flip touch coordinates on the Y axis - x-invert: invert X axis - y-invert: invert Y axis - contact-threshold: - moving-threshold: Rob -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
