On Fri, Mar 28, 2014 at 08:27:04AM +0000, Matthew Garrett wrote: > On Fri, Mar 28, 2014 at 01:24:52AM -0700, Dmitry Torokhov wrote: > > On Fri, Mar 28, 2014 at 08:20:04AM +0000, Matthew Garrett wrote: > > > On Fri, Mar 28, 2014 at 12:56:55AM -0700, Dmitry Torokhov wrote: > > > > > > > I am still unsure if we shoudl be adding these new IDs to serio core... > > > > Can't the X driver take a peek at ACPI devices on it's own? > > > > > > In the (admittedly unlikely) event of multiple PS/2 trackpads, how do > > > you know which one corresponds to which ACPI device? > > > > So far I have not seen a single instance of a laptop with 2 touchpads > > and I doubt external PS/2 ones will ever make come back. > > Right, we can hack around it based on what we've seen so far. But it > seems more attractive to fix it in such a way that we won't behave > inappropriately even if someone does do something utterly unexpected in > future. For instance, some ARM devices have i8042-like serio - if the > underlying device is exposed in device tree, it'd be nice to be able to > expose that to userspace without having to modify the core X code. I wonder if on ARM they have the same split description for AUX and KBD ports or of they have proper i8042 parent. ACPI way of describing PS/2 devices is ugly - keyboard gets ports and mice/touchpads are portless and everyone knows that they should use the same as keyboard. I am unconvinced that just storing a string as firmware ID would solve anything other than quirky Lenovos. Thanks. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html