On Fri, Mar 28, 2014 at 4:12 AM, Chen-Yu Tsai <wens@xxxxxxxx> wrote: >> diff --git a/arch/arm/boot/dts/sun4i-a10-a1000.dts b/arch/arm/boot/dts/sun4i-a10-a1000.dts >> index fa746aea..cf18c4d 100644 >> --- a/arch/arm/boot/dts/sun4i-a10-a1000.dts >> +++ b/arch/arm/boot/dts/sun4i-a10-a1000.dts >> @@ -88,6 +88,19 @@ >> pinctrl-names = "default"; >> pinctrl-0 = <&i2c0_pins_a>; >> status = "okay"; >> + #address-cells = <1>; >> + #size-cells = <0>; >> + >> + axp: axp20x@34 { > > Hi, > > Sorry for spotting this just now. I suggest you change it to > > axp209: pmic@34 { > > or > > axp209_pmic@34 { > > to match the ePAPR policy that node names should be generic and > describe functionality. The latter is what some DTs use. Right. Thanks for reviewing this. > Same for all the other files. > > Thanks for working on this! Thank you, -- Carlo Caione -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html