Re: [PATCH] HID: uhid: Add UHID_CREATE2 + UHID_INPUT2

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi David,

On Mon, Mar 24, 2014 at 12:07 PM, David Herrmann <dh.herrmann@xxxxxxxxx> wrote:
> Hi
>
> On Mon, Mar 24, 2014 at 8:04 PM, Petri Gynther <pgynther@xxxxxxxxxx> wrote:
>> This won't be enough. For UHID_CREATE, we need to use
>> ev->u.create.<member> and for UHID_CREATE2, ev->u.create2.<member>.
>> But, I'll collect those in local variables up front, so we can have
>> just one handler function. I'll send the revised diff shortly.
>
> Oh right, In that case I think we can keep the two functions.

Agreed, I think we should keep the the two functions separate. So, is
the diff good as-is?

-- Petri

>
> Thanks
> David
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux