On Sat, Mar 08, 2014 at 03:29:51AM +0100, Christopher Heiny wrote: > Signed-off-by: Christopher Heiny <cheiny@xxxxxxxxxxxxx> > Cc: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx> > Cc: Benjamin Tissoires <benjamin.tissoires@xxxxxxxxxx> > Cc: Linux Walleij <linus.walleij@xxxxxxxxxx> > Cc: David Herrmann <dh.herrmann@xxxxxxxxx> > Cc: Jiri Kosina <jkosina@xxxxxxx> > > --- > > drivers/input/rmi4/rmi_f01.c | 96 ++----------------------------------- > drivers/input/rmi4/rmi_f01.h | 110 +++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 114 insertions(+), 92 deletions(-) $SUBJECT is 83 characters long. Please be more brief and provide a description. [...] > +#define RMI_SLEEP_MODE_NORMAL 0x00 > +#define RMI_SLEEP_MODE_SENSOR_SLEEP 0x01 > +#define RMI_SLEEP_MODE_RESERVED0 0x02 > +#define RMI_SLEEP_MODE_RESERVED1 0x03 > + > +#define RMI_IS_VALID_SLEEPMODE(mode) \ > + (mode >= RMI_SLEEP_MODE_NORMAL && mode <= RMI_SLEEP_MODE_RESERVED1) > + I might be missing something, but these seem like the only defines used in the flash code. Why not keep these in the f01 driver, and export a couple more functions, like rmi_f01_reset() and rmi_f01_set_sleep_mode() ? -Courtney -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
