On 03/06/2014 05:29 PM, Dmitry Torokhov wrote: > On Thu, Mar 06, 2014 at 07:42:30AM +0100, Robert Baldyga wrote: >> Hi, >> >> On 03/05/2014 07:54 PM, Dmitry Torokhov wrote: >>> Hi Robert, >>> >>> On Wed, Mar 05, 2014 at 03:58:17PM +0100, Robert Baldyga wrote: >>>> >>>> -int max8997_write_reg(struct i2c_client *i2c, u8 reg, u8 value) >>>> +int max8997_write_reg(struct regmap *map, u8 reg, u8 value) >>> >>> Why don't you make read/write reg to take struct max8997_dev as argument >>> instead of regmap? regmap seems to be the current implementation du jur, >>> but that is core's detail, functions do not need to care. >>> >>> Thanks. >>> >> >> It's because there are few regmaps in max8997_dev, and read/write reg >> functions has no way to check which regmap should be used. I think it >> would be clearer if I remove this functions and use regmap_read and >> regmap_write instead, because there is no particular purpose for them. > > I see.. Then another question - why do the regmaps belong to the core > of the driver instead of individual functions? Why haptic regmap, for > example, can not be initialized in haptic code instead? > It looks like it would not be a big problem. I will try to prepare new version of this patch including this. Best regards Robert Baldyga Samsung R&D Institute Poland -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
