Hi, On 03/01/2014 08:29 PM, Hans de Goede wrote: > Hi, > > On 03/01/2014 06:17 PM, Carlo Caione wrote: >> On Sat, Mar 1, 2014 at 5:56 PM, Hans de Goede <hdegoede@xxxxxxxxxx> wrote: >>> Hi Carlo, >>> >>> Great work, thanks for all the time you're putting into this! >> >> Hi Hans :) >> >>> I've 2 questions: >>> >>> 1) What dependencies does this patch-set have? Obviously it needs the NMI irq >>> patches for A20, anything else ? I no longer see any use of a special flag >>> for ack on unmask, is that no longer needed ? >> >> Yes, the only dependency is on the NMI controller patch. >> After a discussion with Maxime and Thomas I decided to not push for >> including the special flag for ack on unmask in the irqchip core but >> to use the unmask callback as in the v3 version of the NMI controller >> driver (so no flag needed) >> >>> 2) No poweroff functionality ? That would be really great to have. >> >> Actually in [PATCH 1/7] I support the poweroff using the pm_power_off hook. > > Ah I missed that, cool. > > I'm doing with sunxi hacking for today, but I'll add these to sunxi-devel > and them give them a test run tomorrow. So I've added your patches to my sunxi-devel tree and they work as advertised :) I've also added dt support for the axp209 to the cubietruck dts file, to avoid things becoming a copy and paste fest I've introduced a new axp209.dtsi file, as well as did some fixes to the existing sun?i-a*.dtsi files, see my tree here: https://github.com/jwrdegoede/linux-sunxi/commits/sunxi-devel If you agree this is a good idea feel free to steal it all for the next revision of your patch-set :) Note that I've still left some copy-paste parts inside the per board dts files, specifically things which may differ per board, ie we know already that A10 boards will have a different interrupt parent for the interrupt. Thanks for your work on this! Regards, Hans -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
