On Thu, Feb 13, 2014 at 11:23:44AM -0800, Christopher Heiny wrote: > On 02/12/2014 09:27 PM, Dmitry Torokhov wrote: > >Do not write configuration data in probe(), we have config() for that. > > Then we should call config() in rmi_function_probe() to ensure that > any platform data or device tree configuration settings get written > to the device. Well, yes, we may elect to update device configuration in probe, but then we should not be doing that 2nd time in ->config(). We shoudl pick either one or another. Thanks. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html