On 02/11/2014 06:49 PM, Courtney Cavin wrote:
On Wed, Feb 12, 2014 at 03:17:57AM +0100, Christopher Heiny wrote:
On 02/11/2014 05:59 PM, Courtney Cavin wrote:
On Wed, Feb 12, 2014 at 12:13:30AM +0100, Christopher Heiny wrote:
For rmi_sensor and rmi_function device_types, use put_device() and
the assocated device_type.release() function to clean up related
structures and storage in the correct and safe order.
Signed-off-by: Christopher Heiny <cheiny@xxxxxxxxxxxxx>
Cc: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>
Cc: Benjamin Tissoires <benjamin.tissoires@xxxxxxxxxx>
Cc: Linux Walleij <linus.walleij@xxxxxxxxxx>
Cc: David Herrmann <dh.herrmann@xxxxxxxxx>
Cc: Jiri Kosina <jkosina@xxxxxxx>
Cc: Courtney Cavin <courtney.cavin@xxxxxxxxxxxxxx>
I'm not a huge fan of you taking my patches, re-formatting them and
sending them as your own. More out of principle then actually caring
about ownership. You at least cc'd me on this one....
Sorry - no slight was intended at all! I wasn't sure what the protocol
was for picking up an idea from someone else's patch and building on
that idea, so I just went with the CC. I definitely prefer to attribute
sources correctly - if you could clarify what should be done (beyond the
CC) to acknowledge the author of the original patch, I'd appreciate it.
Sure. In short, follow Documentation/SubmittingPatches , esp. section
12) Sign your work.
Generally the patch should read something like the following:
From: Original Author <original.author@xxxxxxxxxxx>
*BLURB*
Signed-off-by: Original Author <original.author@xxxxxxxxxxx>
[additional.author@xxxxxxxxxxx: changed x and y]
Signed-off-by: Additional Author <additional.author@xxxxxxxxxxx>
Assuming the original author actually signed-off the patch in the first
place, of course. The square bracket part is optional, but can be
helpful for reviewers.
I'm somewhat surprised that you are not aware of this procedure, as this
is how Dmitry has replied to some of your patches in the past.'
Thanks very much.
I was actually aware of that, but thought the work was sufficiently
different from your original patch that applying your Signed-off-by: to
it wouldn't be appropriate (I dislike being signed off on things I don't
necessarily agree with as much as lack of attribution). I'll be less
paranoid about that in the future.
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
