On Tue, Feb 11, 2014 at 04:57:47PM +0000, Opensource [Anthony Olech] wrote: > > -----Original Message----- > > From: Dmitry Torokhov [mailto:dmitry.torokhov@xxxxxxxxx] > > Sent: 11 February 2014 16:29 > ..[snip].. > > > static void da9052_onkey_query(struct da9052_onkey *onkey) { > > > - int key_stat; > > > + int ret, key_stat; > > > > > > - key_stat = da9052_reg_read(onkey->da9052, > > DA9052_EVENT_B_REG); > > > - if (key_stat < 0) { > > > + ret = da9052_reg_read(onkey->da9052, DA9052_STATUS_A_REG); > > > + if (ret < 0) { > > > dev_err(onkey->da9052->dev, > > > - "Failed to read onkey event %d\n", key_stat); > > > + "Failed to read onkey event err=%d\n", ret); > > > + key_stat = false; > > > > Why do you need this assignment? Also, key_stat is integer, why are we > > using boolean values for it? > > > > > } else { > > > /* > > > * Since interrupt for deassertion of ONKEY pin is not > > > * generated, onkey event state determines the onkey > > > * button state. > > > */ > > > - key_stat &= DA9052_EVENTB_ENONKEY; > > > + if (ret & DA9052_STATUSA_NONKEY) > > > + key_stat = false; > > > + else > > > + key_stat = true; > > > > It seems to me that the relevant changes are replacement of > > DA9052_EVENT_B_REG -> DA9052_STATUS_A_REG in da9052_reg_read() > > and doing: > > > > key_stat &= DA9052_STATUSA_NONKEY; > > input_report_key(onkey->input, KEY_POWER, !key_stat); > > > > Right? > > Right as far as the register and the bit within it. > > However, should the register read fail due to the PMIC not responding > on the i2c bus then the previous code would just loop round the work > queue. By explicitly using key_stat as a boolean it makes the code > very clear that in the case of failure a 'false' value is set. Then it should be defined as boolean. > As it > was the negative value of the error code would be treated as true, > since -EFAULT being non-zero will be treated as true. This is however not what your patch description said it does; it only mentioned the incorrect register assignment. Maybe we shoudl do the following then: ... } else { bool pressed = !(ret & DA9052_STATUSA_NONKEY); input_report_key(onkey->input, KEY_POWER, pressed); input_sync(onkey->input); if (pressed) schedule_work(...); } And mention that we are changing polling (no longer re-poll on read errors) in addition to changing register/bits used. Thanks. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
