On Wednesday 05 of February 2014 09:41:16 you wrote: > On Wed, Feb 5, 2014 at 1:08 AM, <simon@xxxxxxxxxxxxx> wrote: > > > Ahh... please disregard this. 2/5 should have the same fix for zero > > > force > > > as > > > we have right now - it should effectively stop the effect when the force > > > is zero. > > > > Hi, > > We need to think carefully on this as a '+10' combined with '-10' force > > will result in '0'; however we do not want to deactivate the wheel > > (no-resistance mode) as this will result in 'ticking' on the wheel as > > force transitions through 0.... ideally we'd need to know that there are > > no forces set. > > No problem Simon, this is thought about: > If forces are active, and they cancel out, hid_lg4ff_start_combined is > called with 0 force (scaled_x = 0x80), instead of hid_lg4ff_stop_combined > as you assumed. Okay, so to set things straight: I should modify to patch to send 0x13 when the effect is fully stopped and use 0x11 0x80 to only zeroize the force when the overall force is zero? My DFP doesn't differentiate between these states so I cannot tell what is the right thing to do. Michal -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
