Hi On Mon, Feb 3, 2014 at 5:52 PM, Benjamin Tissoires <benjamin.tissoires@xxxxxxxxx> wrote: [snip] >>>>> + - void (*request) (struct hid_device *hdev, struct hid_report *report, >>>>> + int reqtype) >>>>> + Send an HID request on the ctrl channel. "report" contains the report that >>>>> + should be sent and "reqtype" the request type. Request-type can be >>>>> + HID_REQ_SET_REPORT or HID_REQ_GET_REPORT. >>>>> + This callback is optional. If not provided, HID core will assemble a raw >>>>> + report following the HID specs and send it via the ->raw_request() callback. >>> >>> This is not true currently. Aren't we missing a commit in the original series? >>> But I would love seeing this come true. >> >> You're talking about the ->request() to ->raw_request() conversion? >> Indeed, that hasn't been implemented. But it should be rather easy to >> do, right? I will prepare a patch for that so we can apply this >> documentation unchanged. > > Don't bother doing it, I have already made it yesterday :) > > The documentation would still need to be cleaned to remove > hid_input_event callback... So I can take it in the next round of > ll_transport cleanup if you are ok too. Perfect, all fine with me! Thanks David -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
