Hi Frank, just a quick review: On Fri, Jan 31, 2014 at 12:32 PM, Frank Praznik <frank.praznik@xxxxxxxxx> wrote: > Currently there is no reliable way for a device module or hidraw application to > retrieve the client MAC address of the associated wireless device. This series > of patches adds a stable way of retrieving this information. Well, if I look at the uevent of a Bluetooth mouse I have: $ cat /sys/devices/pci0000\:00/0000\:00\:14.0/usb3/3-2/3-2\:1.0/bluetooth/hci0/hci0\:43/0005\:046D\:B00D.001F/uevent DRIVER=hid-generic HID_ID=0005:0000046D:0000B00D HID_NAME=Ultrathin Touch Mouse HID_PHYS=00:10:60:ea:df:ae HID_UNIQ=00:1f:20:96:33:47 MODALIAS=hid:b0005g0001v0000046Dp0000B00D I would say that HID_UNIQ is the client MAC address set by hidp, no? So you don't need to duplicate the info by adding a new field in hid_device. I also have few general comments on the patches, I'll comment in them. Cheers, Benjamin > > The first patch adds a new client_addr member to the hid_device struct. This > member, when populated, will be guaranteed to contain the client hardware > address of a connected wireless device. > > The second patch modifies HIDP to populate the client_addr member of the > hid_device struct with the client MAC address of the connected wireless device. > > The third patch adds support for setting the client_addr value in a uhid > device. > > The final patches add support for retrieving the client_addr value as a string > in the hidraw interface via a new ioctl called HIDIOCGRAWCLIENTADDR. The > hidraw documentation and example program are also updated. > -- > To unsubscribe from this list: send the line "unsubscribe linux-input" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
