On Mon, Jan 27, 2014 at 11:54:22AM -0800, Greg Kroah-Hartman wrote: > On Mon, Jan 27, 2014 at 08:09:55PM +0100, Tom Gundersen wrote: > > Commit 78551277e4df5: "Input: i8042 - add PNP modaliases" had a bug, where the > > second call to MODULE_DEVICE_TABLE() overrode the first resulting in not all > > the modaliases being exposed. > > > > This fixes the problem by including the name of the device_id table in the > > __mod_*_device_table alias, allowing us to export several device_id tables > > per module. > > > > Suggested-by: Kay Sievers <kay@xxxxxxxx> > > Cc: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx> > > Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> > > Cc: Rusty Russell <rusty@xxxxxxxxxxxxxxx> > > --- > > include/linux/module.h | 2 +- > > scripts/mod/file2alias.c | 14 +++++++++----- > > 2 files changed, 10 insertions(+), 6 deletions(-) > > Ah, very nice, I've wanted this for a while now, it would make a number > of different drivers much smaller and simpler to add new device ids to > (no multiple lists of ids, one for the module loader and one for the > sub-driver that is in the single file.) > > If this doesn't break any userspace tools, I have no objection to it at > all: > > Acked-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> Looks great to me as long as module tools keep working. Thanks. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
