On Tue, Jan 28, 2014 at 12:10:54AM +0400, Alexey Khoroshilov wrote: > There is usb_get_dev() in gtco_probe(), but there is no usb_put_dev() > anywhere in the driver. > > As pointed out by Dmitry Torokhov: > The lifetime of gtco structure is already directly tied to lifetime of > usb_dev: when destroying usb_dev driver core will call remove() function > of currently bound driver (in our case gtco) which will destroy gtco > memory. Taking additional reference is not needed here. > > Found by Linux Driver Verification project (linuxtesting.org). > > Signed-off-by: Alexey Khoroshilov <khoroshilov@xxxxxxxxx> Applied, thank you. > --- > drivers/input/tablet/gtco.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/input/tablet/gtco.c b/drivers/input/tablet/gtco.c > index caecffe8caff..858045694e9d 100644 > --- a/drivers/input/tablet/gtco.c > +++ b/drivers/input/tablet/gtco.c > @@ -848,7 +848,7 @@ static int gtco_probe(struct usb_interface *usbinterface, > gtco->inputdevice = input_dev; > > /* Save interface information */ > - gtco->usbdev = usb_get_dev(interface_to_usbdev(usbinterface)); > + gtco->usbdev = interface_to_usbdev(usbinterface); > gtco->intf = usbinterface; > > /* Allocate some data for incoming reports */ > -- > 1.8.3.2 > -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
