Re: [PATCH v3] ims-pcu: Add commands supported by the new version of the FW

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jan 22, 2014 at 05:20:25AM -0800, Andrey Smirnov wrote:
> +static int ims_pcu_write_ofn_config(struct ims_pcu *pcu, u8 addr, u8 data)
> +{
> +	u8 buffer[] = { addr, data };
> +	int error;
> +	u16 result;
> +
> +	error = ims_pcu_execute_command(pcu, OFN_SET_CONFIG,
> +					&buffer, sizeof(buffer));
> +	if (error)
> +		return error;
> +
> +	result = (s16)get_unaligned_le16(pcu->cmd_buf + OFN_REG_RESULT_OFFSET);
> +	if ((result < 0)

I am fairly certain this does not even compile, but even if it did,
result is declared u16 so even if you do the cast above the comparison
will always be false.

Thanks.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux