On Fri, Jan 10, 2014 at 09:02:10AM +0000, Opensource [Anthony Olech] wrote: > > -----Original Message----- > > From: Dmitry Torokhov [mailto:dmitry.torokhov@xxxxxxxxx] > > > > I am uncomfortable with the touchscreen portion of this driver ignoring the > > framework of it's MFD core and mixing native IRQ management with the > > ones done through the core. > > > > What would happen if somebody changes da9052_request_irq() to do some > > thing more than it is doing now so that your open-coded duplicate of the > > same in da9052_ts_probe() is no longer equivalent? Or > > da9052_disable_irq() no longer works correctly with IRQs allocated by this > > sub-module? > > Thanks. > > -- > > Dmitry > Hi Dmitry, > > unfortunately the PMIC is a multifunction device and the component > drivers come under different subsystem maintainers. Thus it is not > possible to do one patch in one go to change them all. This could be arranged if you really want to do that. You could post a patch series and have various maintainers ack it and then Samuel could take it all through MFD tree. This is up to you however. The change does not fix any bugs and error unwinding paths in the input portion of the driver are simple enough, so I do not see a very strong reason for moving to managed devices. I said that I would not be opposed to this (given that conversion is solid), but that was never a request form me. Thanks. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
