Re: [PATCH v2] input: synaptics-rmi4 - use snprintf instead of sprintf in rmi_i2c.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 01/09/2014 12:48 PM, Dmitry Torokhov wrote:
Christopher Heiny<cheiny@xxxxxxxxxxxxx>  wrote:
>On 01/09/2014 12:28 AM, Dmitry Torokhov wrote:
>>On Thu, Jan 09, 2014 at 12:04:54AM -0800, Dmitry Torokhov wrote:
>>>On Wed, Jan 08, 2014 at 05:18:39PM -0800, Christopher Heiny wrote:
>>>>This is a trivial change to replace the sprintf loop with snprintf
>using
>>>>up-to-date format capability.
>>>
>>>Hmm, how about we do this instead:
>>
>>And another small one...
>>
>>Input: synaptics-rmi4 - transport name should be a const pointer
>>
>>From: Dmitry Torokhov<dmitry.torokhov@xxxxxxxxx>
>>
>>Signed-off-by: Dmitry Torokhov<dmitry.torokhov@xxxxxxxxx>
>
>Looks good to me.  I think the correct protocol is to Ack the patch,
>so...
>
>Acked-by: Christopher Heiny<cheiny@xxxxxxxxxxxxx>
Both or only the const name one?


The const name one only at this point. I have a couple of comments on the debug output, one.
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux