On Thu, Jan 02, 2014 at 06:49:59PM +0000, Mark Brown wrote: > On Sun, Dec 15, 2013 at 03:33:37AM -0800, Dmitry Torokhov wrote: > > On Tue, Dec 10, 2013 at 03:43:11PM -0800, Stephen Boyd wrote: > > > > + regmap = dev_get_regmap(pdev->dev.parent, NULL); > > > + if (!regmap) > > > + return -ENODEV; > > > And you are leaking memory here... > > He's not, dev_get_regmap() just gets a pointer to an existing regmap - > no reference is taken and nothing is allocated. It's a helper that's > mainly there so that generic code can be written without needing the > regmap to be passed around. The caller is responsible for ensuring that > it will stick around for as long as it's used (generally by having it > lifetime managed with the device). I was not talking about data returned by dev_get_regmap() but all other memory that was allocated before as this was pre devm conversion of the driver. Thanks. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
