On Mon, Dec 30, 2013 at 06:05:25PM -0800, Christopher Heiny wrote: > This patch fixes some bugs in handling of the RMI4 attention line GPIO. > > 1) in enable_sensor(), eliminate the complicated check on ATTN and just > call process_interrupt_requests(). This will have minimal overhead if ATTN > is not asserted, and clears the state of the RMI4 device in any case. > > 2) Correctly free the GPIO in rmi_driver_remove(). > > 3) in rmi_driver_probe() > - declare the name of the attention gpio (GPIO_LABEL) > - use gpio_request_one() to get the gpio and export it. > - simplify (somewhat) conditional gpio acquisition logic and combine > with interrupt setup > > 4) use gpio_is_valid() instead of comparing to 0. > > Signed-off-by: Christopher Heiny <cheiny@xxxxxxxxxxxxx> > Cc: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx> > Cc: Benjamin Tissoires <benjamin.tissoires@xxxxxxxxxx> Applied, thank you. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
