Re: ADXL34X orientation definition

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Monday, December 09, 2013 09:11:38 AM Michael Hennerich wrote:
> On 12/07/2013 10:53 AM, Dmitry Torokhov wrote:
> > Hi Michael,
> > 
> > I was going though Coverity reports and it looks like definition of
> > 
> > #define ADXL346_2D_ORIENT(x)            (((x) & 0x3) >> 4)
> > 
> > is not correct as it will always evaluate to 0. Should the mask be 0x30
> > instead?
> > 
> > Thanks.
> 
> Hi Dmitry,
> 
> Good catch!
> 
> Yes, of course  - the mask should be 0x30.
> Shall I send a patch?

That would be great.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux