[PATCH] HID: logitech-dj: add HIDRAW dependency in Kconfig

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



hid-logitech-dj.c driver needs hidraw to work correctly. Without
hidraw, hid-logitech-dj.c fails during probe() and Logitech
Unifying devices HID reports aren't recognized.

Signed-off-by: Olivier Gay <ogay@xxxxxxxxxxxx>
Signed-off-by: Nestor Lopez Casado <nlopezcasad@xxxxxxxxxxxx>
Signed-off-by: Mathieu Meisser <mmeisser@xxxxxxxxxxxx>
---

Hi everyone,

this adds a HIDRAW dependency in Kconfig for hid-logitech-dj.c
driver. The driver uses hidraw and needs it to work correctly.

Without hidraw if a Logitech Unifying device is plugged, the driver
fails during probe() and Logitech Unifying devices HID reports aren't
recognized. This has been the cause of some confusion. Some Linux and
Android distributions had HID_LOGITECH_DJ enabled without HIDRAW and
the Unifying mice and keyboards would simply not work (no cursor
tracking / no keyboard typing).

Best regards,

Olivier

 drivers/hid/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig
index 329fbb9..c8a66b9 100644
--- a/drivers/hid/Kconfig
+++ b/drivers/hid/Kconfig
@@ -344,6 +344,7 @@ config HID_LOGITECH
 
 config HID_LOGITECH_DJ
 	tristate "Logitech Unifying receivers full support"
+	depends on HIDRAW
 	depends on HID_LOGITECH
 	---help---
 	Say Y if you want support for Logitech Unifying receivers and devices.
-- 
1.8.4

--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux