Re: [PATCH v2] Input:Add support for DualPoint device on Dell XT2 model

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Dmitry

2013/12/2 Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>:
> On Wed, Nov 27, 2013 at 04:19:05PM +0800, Tommy Will wrote:

>
> OK, fair enough. I will apply the patch, but I think the ALPS driver is
> becoming a bit too unwieldy. It looks like we should split it into
> alps-st (that woudl handle older single-touch models) and alps-mt (for
> the newer multi-touch ones) and maybe a support library for the common
> code.

Thanks for your suggestion. I would consider your idea and try to make
the patch later.

To be honest, not only splitting the file into alps-st and alps-mt, I
also want to rewrite some of ALPS driver's logic.
Some source code seems not exactly and some are hard to be reused later.
However it may cause huge changes and I'm not sure if such
modification would have side-effect or pass the
review and be applied.

# To be honest, I have no confidence to rewrite the logic without
causing any side-effect. Too many models exists
and I could not have chance to test all of them.

-- 
Best Regards,
Tommy
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux