On Tue, Nov 26, 2013 at 05:20:13PM -0800, Guenter Roeck wrote: > On 11/26/2013 10:58 AM, Dmitry Torokhov wrote: > >Hi Guenter, > > > >On Mon, Nov 25, 2013 at 08:39:04PM -0800, Guenter Roeck wrote: > >>Simplify the code and create mandatory 'name' attribute by using > >>new hwmon API. > > > >So this moves hwmon attributes from the parent i2c device to the hwmon > >device, right? Would not that break userspace which expects to find the > >attributes where they were? > > > > In addition to Jean's earlier comments ... s/i2c/spi/, I assume. spi devices > don't create the mandatory name attribute automatically, which means > that the created hwmon device was not recognized by standard user space > applications (eg the sensors command or anything else using libsensors) > in the first place. Which in turn means that only applications which don't > support the standard hwmon ABI - if there are any - would be affected. > What we are more concerned about is to make sure that applications > which _do_ follow the hwmon ABI are working. OK, fair enough, I'll apply this then. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
