On Tue, Oct 22, 2013 at 01:02:53PM +0100, Felipe Balbi wrote: > Hi, > > On Tue, Oct 22, 2013 at 10:42:00AM +0200, Sebastian Andrzej Siewior wrote: > > On 10/21/2013 10:13 PM, Felipe Balbi wrote: > > > diff --git a/drivers/input/touchscreen/ti_am335x_tsc.c b/drivers/input/touchscreen/ti_am335x_tsc.c > > > index e1c5300..b61df9d 100644 > > > --- a/drivers/input/touchscreen/ti_am335x_tsc.c > > > +++ b/drivers/input/touchscreen/ti_am335x_tsc.c > > > @@ -348,9 +348,16 @@ static int titsc_parse_dt(struct platform_device *pdev, > > > if (err < 0) > > > return err; > > > > > > - err = of_property_read_u32(node, "ti,coordiante-readouts", > > > + /* > > > + * try with new binding first. If it fails, still try with > > > + * bogus, miss-spelled version. > > > + */ > > > + err = of_property_read_u32(node, "ti,coordinate-readouts", > > > &ts_dev->coordinate_readouts); > > > if (err < 0) > > > + err = of_property_read_u32(node, "ti,coordiante-readouts", > > > + &ts_dev->coordinate_readouts); > > > + if (err < 0) > > > return err; > > > > Thanks, very good. Do we keep this fallback for ever or just for a year > > or two? > > That's for DT maintainers to decide but considering DT is an ABI, I > guess we need to keep for 30 years or so :-p We keep it as long as we have to. If no-one's relying on the typo by the next merge window, I see no reason we'd have to keep support for the typo beyond that. If someone's shipped a device with a dtb with the typo hard-coded into some ROM, that's another matter... It might be worth printing a warning in the case of the typo'd version, suggesting correcting the DT. That will encourage anyone with a broken dt to get a fixed one. Mark. -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
