On Tue, Nov 12, 2013 at 10:47:57AM +0000, Alexander Shiyan wrote:
> Hello.
>
> > On Tue, Nov 12, 2013 at 10:07:13AM +0000, Alexander Shiyan wrote:
> > > This patch adds a new driver for the beeper controlled via GPIO pin.
> > > The driver does not depend on the architecture and is positioned as
> > > a replacement for the specific drivers that are used for this function.
> > >
> > > Signed-off-by: Alexander Shiyan <shc_work@xxxxxxx>
> ...
> > > diff --git a/Documentation/devicetree/bindings/input/gpio-beeper.txt b/Documentation/devicetree/bindings/input/gpio-beeper.txt
> ...
> > > +Example:
> > > +
> > > +beeper: input@0 {
> > > + compatible = "gpio-beeper";
> > > + reg = <0>;
> > > + gpios = <&gpio3 23 0>;
> > > +};
> >
> > What are the reg / unit-address for?
>
> Just an example from "simple-bus" container.
If they have no meaning, they should go. They're unnecessary and make
things more confusing.
I'd expect the example to be:
beeper: beeper {
compatible = "gpio-beeper";
gpios - <&gpio3 23 0>;
};
And if we have multiple beepers, something like:
beeper0: beeper0 { ... };
beeper1: beeper1 { ... };
Thanks,
Mark.
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
