Re: [patch] Input: tnetv107x-keypad - make irqs signed for error handling

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Nov 07, 2013 at 10:52:40AM +0300, Dan Carpenter wrote:
> There is a bug in keypad_probe() where we do:
> 
> 	kp->irq_press   = platform_get_irq_byname(pdev, "press");
> 	kp->irq_release = platform_get_irq_byname(pdev, "release");
> 	if (kp->irq_press < 0 || kp->irq_release < 0) {
> 
> The problem is that these irq variables are unsigned so the error
> handling doesn't work.  I've changed them to signed values.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>


Applied, thank you.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux