Re: [PATCHv3 3/3] Input: twl4030-pwrbutton: simplify driver using devm_*

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Oct 23, 2013 at 08:25:24PM +0300, Aaro Koskinen wrote:
> Hi,
> 
> On Wed, Oct 23, 2013 at 06:47:15PM +0200, Sebastian Reichel wrote:
> >  static int __exit twl4030_pwrbutton_remove(struct platform_device *pdev)
> >  {
> >  	struct input_dev *pwr = platform_get_drvdata(pdev);
> > -	int irq = platform_get_irq(pdev, 0);
> >  
> > -	free_irq(irq, pwr);
> >  	input_unregister_device(pwr);
> 
> The same bug still exists. You don't need to unregister manually any more,
> this whole function can be just reduced to "return 0;".

then it can be removed altogether, no ?

-- 
balbi

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux