Hi Greg, On Mon, Oct 07, 2013 at 06:08:23PM -0700, Greg Kroah-Hartman wrote: > From: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> > > Convert the serio sysfs fiels to use the DEVICE_ATTR_RO() macros to make > it easier to audit the correct sysfs file permission usage. Sorry for the delay. Frankly I am not a fan of DEVICE_ATTR macros as it forces particular naming of the attribute structures and methods and forces us to lose the module prefix in names. I prefer all functions and file-scope variables have module prefix because in the absence of language-supported namespaces this is the one thing that insulates drivers from changes in shared headers. Thanks. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html