On Thu, 17 Oct 2013, Benjamin Tissoires wrote: > > Revert some changes done in 774638386826621c984ab6994439f474709cac5e. > > > > Revert all changes done in hidinput_calc_abs_res as it mistakingly used > > "Unit" item exponent nibbles to affect resolution value. This wasn't > > breaking resolution calculation of relevant axes of any existing > > devices, though, as they have only one dimension to their units and thus > > 1 in the corresponding nible. > > > > Revert to reading "Unit Exponent" item value as a signed integer in > > hid_parser_global to fix reading specification-complying values. This > > fixes resolution calculation of devices complying to the HID standard, > > including Huion, KYE, Waltop and UC-Logic graphics tablets which have > > their report descriptors fixed by the drivers. > > > > Explanations follow. [ ... snip ... ] > I finally understood what you mean here, and why I introduced such a change. > I have weird report descriptors available in the field which are > making a funny use of units: Ok, it took me quite some time to figure this all out. Good work Nikolai, thanks. I am about to apply it, just a minor thing -- you seem to have forgotten your Signed-off-by: line in the patch. Could you please send it to me, so that I can ammend it to the patch and apply it? Thanks. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
