On Sun, Oct 13, 2013 at 10:50 PM, Will Tommy <tommywill2011@xxxxxxxxx> wrote: >> I assume start_bit and end_bit can never be negative, because the code >> that calculates e.g. x_map will populate at most bits 0..(x_bits-1)? > > Do you mean it's not good to define start_bit & end_bit as "int" since they have > no chance to be negative ? Actually, "unsigned char" is much better. No type change needed - I was just checking to make sure it wasn't a risk, since getting a negative number in there would really throw off the math... -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
