Hi Luosong, ok, your mailer still sends emails as HTML, and it also mangles the tabs, which is not good for the LKML. The commit message is a little bit fuzzy and does not follow the kernel rules. I'll send a followup patch correctly formatted so that we can all switch to something else. Cheers, Benjamin On 25/09/13 09:14, Lamson_Luo wrote: > Dear,Sir > > OK,I have modified some problems for this patch as follows: > (1) I have used my real name ,my name is Luosong, my email is > android@xxxxxxxxxxxxxxxx <mailto:android@xxxxxxxxxxxxxxxx> > (2) I have sorted > alphabetically the PID you are adding both in hid-multitouch,c and hid-ids.h(0003 > to e100) > (3) I have tested them in our products. > > In addition, I have added the patch into the attachment > > > commit ef879474d31fbf671f1eadda1b618a606c28e680 Mon Sep 17 00:00:00 2001 > From: Luosong <android@xxxxxxxxxxxxxxxx> > Date: Wed, 25 Sep 2013 06:22:48 +0800 > Subject: [PATCH] "0101,e100,0102,0106,010a", these ID are our GeneralTouch's > new products change to "MT_QUIRK_SLOT_IS_CONTACTID",doing > this is for correcting a bug for our GeneralTouch'products > > Signed-off-by: Luosong <android@xxxxxxxxxxxxxxxx> > > --- > drivers/hid/hid-ids.h | 5 +++++ > drivers/hid/hid-multitouch.c | 19 +++++++++++++++++-- > 2 files changed, 22 insertions(+), 2 deletions(-) > > diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h > index e60e8d5..9a91dee 100644 > --- a/drivers/hid/hid-ids.h > +++ b/drivers/hid/hid-ids.h > @@ -332,6 +332,11 @@ > #define USB_VENDOR_ID_GENERAL_TOUCH 0x0dfc > #define USB_DEVICE_ID_GENERAL_TOUCH_WIN7_TWOFINGERS 0x0003 > #define USB_DEVICE_ID_GENERAL_TOUCH_WIN8_PWT_TENFINGERS 0x0100 > +#define USB_DEVICE_ID_GENERAL_TOUCH_WIN8_PIT_0101 0x0101 > +#define USB_DEVICE_ID_GENERAL_TOUCH_WIN8_PIT_0102 0x0102 > +#define USB_DEVICE_ID_GENERAL_TOUCH_WIN8_PIT_0106 0x0106 > +#define USB_DEVICE_ID_GENERAL_TOUCH_WIN8_PIT_010A 0x010a > +#define USB_DEVICE_ID_GENERAL_TOUCH_WIN8_PIT_E100 0xe100 > > #define USB_VENDOR_ID_GLAB 0x06c2 > #define USB_DEVICE_ID_4_PHIDGETSERVO_30 0x0038 > diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c > index 5e5fe1b..cb3250c 100644 > --- a/drivers/hid/hid-multitouch.c > +++ b/drivers/hid/hid-multitouch.c > @@ -250,12 +250,12 @@ static struct mt_class mt_classes[] = { > { .name = MT_CLS_GENERALTOUCH_TWOFINGERS, > .quirks = MT_QUIRK_NOT_SEEN_MEANS_UP | > MT_QUIRK_VALID_IS_INRANGE | > - MT_QUIRK_SLOT_IS_CONTACTNUMBER, > + MT_QUIRK_SLOT_IS_CONTACTID, > .maxcontacts = 2 > }, > { .name = MT_CLS_GENERALTOUCH_PWT_TENFINGERS, > .quirks = MT_QUIRK_NOT_SEEN_MEANS_UP | > - MT_QUIRK_SLOT_IS_CONTACTNUMBER > + MT_QUIRK_SLOT_IS_CONTACTID > }, > > { .name = MT_CLS_FLATFROG, > @@ -1173,6 +1173,21 @@ static const struct hid_device_id mt_devices[] = { > { .driver_data = MT_CLS_GENERALTOUCH_PWT_TENFINGERS, > MT_USB_DEVICE(USB_VENDOR_ID_GENERAL_TOUCH, > USB_DEVICE_ID_GENERAL_TOUCH_WIN8_PWT_TENFINGERS) }, > + { .driver_data = MT_CLS_GENERALTOUCH_TWOFINGERS, > + MT_USB_DEVICE(USB_VENDOR_ID_GENERAL_TOUCH, > + USB_DEVICE_ID_GENERAL_TOUCH_WIN8_PIT_0101) }, > + { .driver_data = MT_CLS_GENERALTOUCH_PWT_TENFINGERS, > + MT_USB_DEVICE(USB_VENDOR_ID_GENERAL_TOUCH, > + USB_DEVICE_ID_GENERAL_TOUCH_WIN8_PIT_0102) }, > + { .driver_data = MT_CLS_GENERALTOUCH_PWT_TENFINGERS, > + MT_USB_DEVICE(USB_VENDOR_ID_GENERAL_TOUCH, > + USB_DEVICE_ID_GENERAL_TOUCH_WIN8_PIT_0106) }, > + { .driver_data = MT_CLS_GENERALTOUCH_PWT_TENFINGERS, > + MT_USB_DEVICE(USB_VENDOR_ID_GENERAL_TOUCH, > + USB_DEVICE_ID_GENERAL_TOUCH_WIN8_PIT_010A) }, > + { .driver_data = MT_CLS_GENERALTOUCH_PWT_TENFINGERS, > + MT_USB_DEVICE(USB_VENDOR_ID_GENERAL_TOUCH, > + USB_DEVICE_ID_GENERAL_TOUCH_WIN8_PIT_E100) }, > > /* Gametel game controller */ > { .driver_data = MT_CLS_NSMU, > -- > 1.7.9.5 > > ********************************************************************************** > ********************************************************************************************** > > Hi, > > On 17/09/13 04:15, Lamson_Luo wrote: >> Hi,Sir >> I am sorry to trouble you . >> >> I want to ask you something about adding our GeneralTouch's patch >> >> is it OK? > > well, it is nearly ok: > - I have nothing against the patch, regarding the fact that you are > working for GeneralTouch and that I hope that you have tested it against > the new devices and the older ones. > - small nitpick in the patch anyway, could you please just sort > alphabetically the PID you are adding both in hid-multitouch,c and hid-ids.h > - your mail client continue to try to send your messages as HTML, which > are rejected by linux-input@vger... > - you should inline the patch in the mail. The simplest way to do that > is to use the commands "git format-patch" then "git send-email" which > will do all the tedious work for you (or nearly) > - the "from" field and your Signed-off-by is not compliant with the > kernel rules: > see "12) Sign your work" in the file Documentation/SubmittingPatches in > the kernel tree (Jiri already pointed this link) The important part is: > "using your real name (sorry, no pseudonyms or anonymous contributions.)" > >> or what should we do ? > > follow the rule number 10) in the previously mentioned document: > "Don't get discouraged. Re-submit." > >> >> which linux version is it updated in ? > > Given that Jiri is currently attending LPC in New Orleans, don't expect > a very fast answer from him currently. Then, once it will land in his > tree, it will be scheduled for the next Linux release (3.12 or 3.13), > and Jiri may also submit it to stable if there are no conflicts (i.e. in > this case 3.10 and 3.11 I would say). > > Cheers, > Benjamin > >> >> >> ------------------------------------------------------------------------ >> >> >> >> Please feel free to contact me if you have any question. >> Thanks & Best Regards >> >> Email: android@xxxxxxxxxxxxxxxx <mailto:android@xxxxxxxxxxxxxxxx> >> R&D Department >> GeneralTouch Technology Co., Ltd. >> >> *发件人：* Lamson_Luo <mailto:android@xxxxxxxxxxxxxxxx> >> *发送时间：* 2013-09-10 11:20 >> *收件人：* jkosina <mailto:jkosina@xxxxxxx> >> *抄送：* linux-input <mailto:linux-input@xxxxxxxxxxxxxxx>; Henrik >> Rydberg <mailto:rydberg@xxxxxxxxxxx>; Benjamin Tissoires >> <mailto:benjamin.tissoires@xxxxxxxxxx> >> *主 > 题：* Re: Re: [PATCH] update my generaltouch driver for linux by luosong >> Dear,Jiri Kosina >> thanks for your reply >> >> for your message, my reply is as follows: >> >> 1) >> On Mon, 9 Sep 2013, android wrote: >> >>> I am a software engineer from GeneralTouch Technology Co., Ltd. >>> >>> I want to add some driver patches to the linux kernel . >>> >>> I do these jobs in hid-ids.h and hid-multitouch.c >> >> Adding Henrik and Benjamon to CC for the hid-multitouch driver. >> >> [RE]: >> yes,I added them. >> but when I tried to send this mail to >> linux-input(linux-input@xxxxxxxxxxxxxxx ) ,I failed to do it. >> the reference info is : >> # host vger.kernel.org[209.132.180.67] said: 550 5.7.1 Content-Policy >> reject msg: The message contains HTML, therefore we consider it SPAM. >> Send pure TEXT/PLAIN if you are not a spammer. BF:_; S1750878Ab3IIIli >> (in reply to end of DATA command) _ >> >> 2) >> >>> The main changes in hid driver are like those: >>> (1)add our new products into kernel driver >>> +#define USB_DEVICE_ID_GENERAL_TOUCH_WIN8_PIT_0102 0x0102 >>> +#define USB_DEVICE_ID_GENERAL_TOUCH_WIN8_PIT_E100 0xe100 >>> +#define USB_DEVICE_ID_GENERAL_TOUCH_WIN8_PIT_0101 0x0101 >>> +#define USB_DEVICE_ID_GENERAL_TOUCH_WIN8_PIT_0106 0x0106 >>> +#define USB_DEVICE_ID_GENERAL_TOUCH_WIN8_PIT_010A 0x010a >>> (2) correct previous bug >>> - MT_QUIRK_SLOT_IS_CONTACTNUMBER >>> + MT_QUIRK_SLOT_IS_CONTACTID >> >> This needs explanation / clarification in the changelog. >> >> >> [RE]: >> >> I will give you the reference changelog: >> >> commit 94e68a8c72e2dc300a08a751cd52d9a97cbb43ac >> Author: luosong <android@xxxxxxxxxxxxxxxx> >> Date: Tue Sep 10 02:04:46 2013 +0800 >> >> hid-for-generaltouch >> >> "0101,e100,0102,0106,010a", these ID are our GeneralTouch's new products >> change to "MT_QUIRK_SLOT_IS_CONTACTID",doing this is for correcting a bug for our GeneralTouch'products >> Signed-off-by:luosong android@xxxxxxxxxxxxxxxx >> <mailto:android@xxxxxxxxxxxxxxxx> >> >> >> >> >> 3) >>> the content of patch is shown below: >>> >>> From 5db217392e661695058606c7919be7fa6509f1e4 Mon Sep 17 00:00:00 2001 >>> From: luosong android@xxxxxxxxxxxxxxxx >> >> This doesn't look like a RFC-compliant from, I think. >> >> [RE]: >> I got the source by git tool ,I built a branch named >> hid-for-generaltouch ,and I also configured my username and mail. >> >> >> >> 4) >>> Date: Mon, 9 Sep 2013 02:30:10 +0800 >>> Subject: [PATCH] update my generaltouch driver for linux by luosong >> >> Please insert changelog (description of the changes) and Signed-off-by: >> line here, as documented in Documentation/SubmittingPatches >> >> >> [RE]: >> "0101,e100,0102,0106,010a", these ID are our GeneralTouch's new products >> change to "MT_QUIRK_SLOT_IS_CONTACTID",doing this is for correcting a bug for our GeneralTouch'products >> >> 5) >>> --- >>> drivers/hid/hid-ids.h | 5 +++++ >>> drivers/hid/hid-multitouch.c | 19 +++++++++++++++++-- >>> 2 files changed, 22 insertions(+), 2 deletions(-) >>> >>> diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h >>> index ffe4c7a..ca78f09 100644 >>> --- a/drivers/hid/hid-ids.h >>> +++ b/drivers/hid/hid-ids.h >>> @@ -332,6 +332,11 @@ >>> #define USB_VENDOR_ID_GENERAL_TOUCH 0x0dfc >>> #define USB_DEVICE_ID_GENERAL_TOUCH_WIN7_TWOFINGERS 0x0003 >>> #define USB_DEVICE_ID_GENERAL_TOUCH_WIN8_PWT_TENFINGERS 0x0100 >>> +#define USB_DEVICE_ID_GENERAL_TOUCH_WIN8_PIT_0102 0x0102 >>> +#define USB_DEVICE_ID_GENERAL_TOUCH_WIN8_PIT_E100 0xe100 >>> +#define USB_DEVICE_ID_GENERAL_TOUCH_WIN8_PIT_0101 0x0101 >>> +#define USB_DEVICE_ID_GENERAL_TOUCH_WIN8_PIT_0106 0x0106 >>> +#define USB_DEVICE_ID_GENERAL_TOUCH_WIN8_PIT_010A 0x010a >>> >>> #define USB_VENDOR_ID_GLAB 0x06c2 >>> #define USB_DEVICE_ID_4_PHIDGETSERVO_30 0x0038 >>> diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c >>> index cb0e361..9558dde 100644 >>> --- a/drivers/hid/hid-multitouch.c >>> +++ b/drivers/hid/hid-multitouch.c >>> @@ -244,12 +244,12 @@ static struct mt_class mt_classes[] = { >>> { .name = MT_CLS_GENERALTOUCH_TWOFINGERS, >>> .quirks = MT_QUIRK_NOT_SEEN_MEANS_UP | >>> MT_QUIRK_VALID_IS_INRANGE | >>> - MT_QUIRK_SLOT_IS_CONTACTNUMBER, >>> + MT_QUIRK_SLOT_IS_CONTACTID, >>> .maxcontacts = 2 >>> }, >>> { .name = MT_CLS_GENERALTOUCH_PWT_TENFINGERS, >>> .quirks = MT_QUIRK_NOT_SEEN_MEANS_UP | >>> - MT_QUIRK_SLOT_IS_CONTACTNUMBER >>> + MT_QUIRK_SLOT_IS_CONTACTID >>> }, >>> >>> { .name = MT_CLS_FLATFROG, >>> @@ -1191,6 +1191,21 @@ static const struct hid_device_id mt_devices[] = { >>> { .driver_data = MT_CLS_GENERALTOUCH_PWT_TENFINGERS, >>> MT_USB_DEVICE(USB_VENDOR_ID_GENERAL_TOUCH, >>> USB_DEVICE_ID_GENERAL_TOUCH_WIN8_PWT_TENFINGERS) }, >>> + { .driver_data = MT_CLS_GENERALTOUCH_TWOFINGERS, >>> + MT_USB_DEVICE(USB_VENDOR_ID_GENERAL_TOUCH, >>> + USB_DEVICE_ID_GENERAL_TOUCH_WIN8_PIT_0101) }, >>> + { .driver_data = MT_CLS_GENERALTOUCH_PWT_TENFINGERS, >>> + MT_USB_DEVICE(USB_VENDOR_ID_GENERAL_TOUCH, >>> + USB_DEVICE_ID_GENERAL_TOUCH_WIN8_PIT_E100) }, >>> + { .driver_data = MT_CLS_GENERALTOUCH_PWT_TENFINGERS, >>> + MT_USB_DEVICE(USB_VENDOR_ID_GENERAL_TOUCH, >>> + USB_DEVICE_ID_GENERAL_TOUCH_WIN8_PIT_0102) }, >>> + { .driver_data = MT_CLS_GENERALTOUCH_PWT_TENFINGERS, >>> + MT_USB_DEVICE(USB_VENDOR_ID_GENERAL_TOUCH, >>> + USB_DEVICE_ID_GENERAL_TOUCH_WIN8_PIT_0106) }, >>> + { .driver_data = MT_CLS_GENERALTOUCH_PWT_TENFINGERS, >>> + MT_USB_DEVICE(USB_VENDOR_ID_GENERAL_TOUCH, >>> + USB_DEVICE_ID_GENERAL_TOUCH_WIN8_PIT_010A) }, >> >> Your mail client seems to be whitespace-corrupting patches (it ate the >> tabs at least). >> >> Could you please fix all the above and resubmit? >> >> [RE]: >> I will send some attachments to you >> >> >> is it OK? if it is not right,could you help me to modify it? >> >> >> >> >> >> >> *From:* Jiri Kosina <mailto:jkosina@xxxxxxx> >> *Date:* 2013-09-09 21:04 >> *To:* android <mailto:android@xxxxxxxxxxxxxxxx> >> *CC:* linux-input <mailto:linux-input@xxxxxxxxxxxxxxx>; Henrik Rydberg >> <mailto:rydberg@xxxxxxxxxxx>; Benjamin Tissoires >> <mailto:benjamin.tissoires@xxxxxxxxxx> >> *Subject:* Re: [PATCH] update my generaltouch driver for linux by luosong >> On Mon, 9 Sep 2013, android wrote: >> >>> I am a software engineer from GeneralTouch Technology Co., Ltd. >>> >>> I want to add some driver patches to the linux kernel . >>> >>> I do these jobs in hid-ids.h and hid-multitouch.c >> >> Adding Henrik and Benjamon to CC for the hid-multitouch driver. >> >>> The main changes in hid driver are like those: >>> (1)add our new products into kernel driver >>> +#define USB_DEVICE_ID_GENERAL_TOUCH_WIN8_PIT_0102 0x0102 >>> +#define USB_DEVICE_ID_GENERAL_TOUCH_WIN8_PIT_E100 0xe100 >>> +#define USB_DEVICE_ID_GENERAL_TOUCH_WIN8_PIT_0101 0x0101 >>> +#define USB_DEVICE_ID_GENERAL_TOUCH_WIN8_PIT_0106 0x0106 >>> +#define USB_DEVICE_ID_GENERAL_TOUCH_WIN8_PIT_010A 0x010a >>> (2) correct previous bug >>> - MT_QUIRK_SLOT_IS_CONTACTNUMBER >>> + MT_QUIRK_SLOT_IS_CONTACTID >> >> This needs explanation / clarification in the changelog. >> >>> the content of patch is shown below: >>> >>> From 5db217392e661695058606c7919be7fa6509f1e4 Mon Sep 17 00:00:00 2001 >>> From: luosong android@xxxxxxxxxxxxxxxx >> >> This doesn't look like a RFC-compliant from, I think. >> >>> Date: Mon, 9 Sep 2013 02:30:10 +0800 >>> Subject: [PATCH] update my generaltouch driver for linux by luosong >> >> Please insert changelog (description of the changes) and Signed-off-by: >> line here, as documented in Documentation/SubmittingPatches >> >>> --- >>> drivers/hid/hid-ids.h | 5 +++++ >>> drivers/hid/hid-multitouch.c | 19 +++++++++++++++++-- >>> 2 files changed, 22 insertions(+), 2 deletions(-) >>> >>> diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h >>> index ffe4c7a..ca78f09 100644 >>> --- a/drivers/hid/hid-ids.h >>> +++ b/drivers/hid/hid-ids.h >>> @@ -332,6 +332,11 @@ >>> #define USB_VENDOR_ID_GENERAL_TOUCH 0x0dfc >>> #define USB_DEVICE_ID_GENERAL_TOUCH_WIN7_TWOFINGERS 0x0003 >>> #define USB_DEVICE_ID_GENERAL_TOUCH_WIN8_PWT_TENFINGERS 0x0100 >>> +#define USB_DEVICE_ID_GENERAL_TOUCH_WIN8_PIT_0102 0x0102 >>> +#define USB_DEVICE_ID_GENERAL_TOUCH_WIN8_PIT_E100 0xe100 >>> +#define USB_DEVICE_ID_GENERAL_TOUCH_WIN8_PIT_0101 0x0101 >>> +#define USB_DEVICE_ID_GENERAL_TOUCH_WIN8_PIT_0106 0x0106 >>> +#define USB_DEVICE_ID_GENERAL_TOUCH_WIN8_PIT_010A 0x010a >>> >>> #define USB_VENDOR_ID_GLAB 0x06c2 >>> #define USB_DEVICE_ID_4_PHIDGETSERVO_30 0x0038 >>> diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c >>> index cb0e361..9558dde 100644 >>> --- a/drivers/hid/hid-multitouch.c >>> +++ b/drivers/hid/hid-multitouch.c >>> @@ -244,12 +244,12 @@ static struct mt_class mt_classes[] = { >>> { .name = MT_CLS_GENERALTOUCH_TWOFINGERS, >>> .quirks = MT_QUIRK_NOT_SEEN_MEANS_UP | >>> MT_QUIRK_VALID_IS_INRANGE | >>> - MT_QUIRK_SLOT_IS_CONTACTNUMBER, >>> + MT_QUIRK_SLOT_IS_CONTACTID, >>> .maxcontacts = 2 >>> }, >>> { .name = MT_CLS_GENERALTOUCH_PWT_TENFINGERS, >>> .quirks = MT_QUIRK_NOT_SEEN_MEANS_UP | >>> - MT_QUIRK_SLOT_IS_CONTACTNUMBER >>> + MT_QUIRK_SLOT_IS_CONTACTID >>> }, >>> >>> { .name = MT_CLS_FLATFROG, >>> @@ -1191,6 +1191,21 @@ static const struct hid_device_id mt_devices[] = { >>> { .driver_data = MT_CLS_GENERALTOUCH_PWT_TENFINGERS, >>> MT_USB_DEVICE(USB_VENDOR_ID_GENERAL_TOUCH, >>> USB_DEVICE_ID_GENERAL_TOUCH_WIN8_PWT_TENFINGERS) }, >>> + { .driver_data = MT_CLS_GENERALTOUCH_TWOFINGERS, >>> + MT_USB_DEVICE(USB_VENDOR_ID_GENERAL_TOUCH, >>> + USB_DEVICE_ID_GENERAL_TOUCH_WIN8_PIT_0101) }, >>> + { .driver_data = MT_CLS_GENERALTOUCH_PWT_TENFINGERS, >>> + MT_USB_DEVICE(USB_VENDOR_ID_GENERAL_TOUCH, >>> + USB_DEVICE_ID_GENERAL_TOUCH_WIN8_PIT_E100) }, >>> + { .driver_data = MT_CLS_GENERALTOUCH_PWT_TENFINGERS, >>> + MT_USB_DEVICE(USB_VENDOR_ID_GENERAL_TOUCH, >>> + USB_DEVICE_ID_GENERAL_TOUCH_WIN8_PIT_0102) }, >>> + { .driver_data = MT_CLS_GENERALTOUCH_PWT_TENFINGERS, >>> + MT_USB_DEVICE(USB_VENDOR_ID_GENERAL_TOUCH, >>> + USB_DEVICE_ID_GENERAL_TOUCH_WIN8_PIT_0106) }, >>> + { .driver_data = MT_CLS_GENERALTOUCH_PWT_TENFINGERS, >>> + MT_USB_DEVICE(USB_VENDOR_ID_GENERAL_TOUCH, >>> + USB_DEVICE_ID_GENERAL_TOUCH_WIN8_PIT_010A) }, >> >> Your mail client seems to be whitespace-corrupting patches (it ate the >> tabs at least). >> >> Could you please fix all the above and resubmit? >> >> Thanks a lot, >> >> -- >> Jiri Kosina >> SUSE Labs >> >> > > > -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
