Ryan Mallon <rmallon@xxxxxxxxx> wrote: >On 19/09/13 05:48, Dmitry Torokhov wrote: > >> Hi Ryan, >> >> On Wed, Sep 18, 2013 at 08:55:44AM +1000, Ryan Mallon wrote: >>> Rework the code in uinput_inject_event so that it matches the code >in >>> evdev_write and allows injecting more than one event, or zero >events. >> >> After some thinking I went back to the original version of your >patch. >> For justification see 46f49b7a223ac7493e7cf619fb583d11edefc2c2: >> >> "When copy_to/from_user fails in the middle of transfer we should not >> report to the user that read/write partially succeeded but rather >> report -EFAULT right away, so that application will know that it got >> its buffers all wrong. >> >> If application messed up its buffers we can't trust the data fetched >> from userspace and successfully written to the device or if data read >> from the device and transferred to userspace ended up where >application >> expected it to end." > > >Okay, so patch 1 is obviously dropped. Do you want me to resend a fixed > >version of this one, or have you already modified it? I took your original version - is does the right thing. Thanks. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
