On Mon, Sep 16, 2013 at 02:46:24PM +0000, KY Srinivasan wrote: > > > + case VM_PKT_DATA_INBAND: > > > + hv_kbd_on_receive(device, desc); > > > > This is the error handling I mentioned at the top. hv_kbd_on_receive() > > doesn't take into consideration the amount of data we recieved, it > > trusts the offset we recieved from the user. There is an out of bounds > > read. > > What user are you referring to. The message is sent by the host - the user keystroke > is normalized into a fixed size packet by the host and sent to the guest. We will parse this > packet, based on the host specified layout here. > The user means the hypervisor, yes. I don't want the hypervisor accessing outside of the buffer. It is robustness issue. Just check the offset against "bytes_recvd". It's not complicated. If you have a different place where the guest does this then tell me which function to look at. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
